Conversation
…mdns script for ease of use
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the RTSP component's Python testing utilities by adding mDNS service discovery capabilities, dependency management, and comprehensive documentation. It improves the developer experience for testing RTSP server implementations, particularly with the esp-cpp/camera-streamer project.
- Adds mDNS-enabled RTSP client for automatic service discovery
- Creates requirements.txt for Python dependency management
- Provides detailed README documentation for the Python scripts
- Updates main RTSP README to reference Python utilities
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| components/rtsp/python/rtsp_client_mdns.py | New RTSP client with mDNS discovery for automatic server detection |
| components/rtsp/python/requirements.txt | Python dependencies file for easy setup |
| components/rtsp/python/README.md | Comprehensive documentation for Python RTSP utilities |
| components/rtsp/README.md | Updated to reference Python testing utilities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mDNSvariant of thertsp_client.pyexample script to make testingeasier, esp. with the
esp-cpp/camera-streamer project.
requirements.txtfile for easier dependency managementREADME.mdwhich explains how to use the scripts in thertsp/pythonfolder.
rtsp/readmeto point to the python directory for easier discoveryability.Motivation and Context
Allows others to better find and use these tools.
How has this been tested?
Running the scripts and ensuring they work based on the instructions.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.